Added networkzone parameter to agent download and removal of AppMon components #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arthfl
commented
Jul 14, 2021
arthfl
commented
- Added networkzone parameter to OneAgent download from API
- Removed all AppMon components since it's deprecated by now anyways
|
There were some minor issues with this PR. I'm going to merge it though & I'll issue a polishing commit shortly. See fd50c13 |
dmikusa
pushed a commit
that referenced
this pull request
Jul 14, 2021
- Remove DynatraceAppmonAgent from the component list. This was missed when AppMon Agent was removed. - Fixes syntax error with missing `end` block - Fixes Rubocop violation for single line if blocks, use `cmd if expr` syntax intead - Adds referenced but missing method to pull the networkzone property from credentials - Adds docs for the networkzone property - Adds a unit test to validate that networkzone is passed in the URL when present in the binding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.